contracts module #6789
Merged
contracts module #6789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
@AlexPapadakis could you please take care of the clang-format, cmake-format, and inspect errors reported? |
Contributor
Author
|
@hkaiser yes absolutely, I will spend time on it in the Weekend |
isidorostsa
reviewed
Oct 17, 2025
Contributor
isidorostsa
left a comment
isidorostsa
left a comment
There was a problem hiding this comment.
Great work, a couple of nitpicks and we should be able to merge
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Pansysk75
reviewed
Oct 19, 2025
hkaiser
force-pushed
the
contract_test
branch
2 times, most recently
from
487994b to
0040396
Compare
- updated cmake option for enchanced asserts to follow convention - updated fallback logic, added config test for experimental builds - improved documentation - added config test to automatically run the appropriate tests for either native or fallback mode - contracts: Restructure test suite for clarity and completeness - Add comprehensive declaration-based contract failure tests: * declaration_contracts_fail_pre.cpp * declaration_contracts_fail_post.cpp * declaration_contracts_fail_contract_assert.cpp - Remove redundant test files (contract_fail.cpp, simple_contracts_*) - Update CMakeLists.txt with proper test organization: * Declaration tests: C++26 syntax (__cpp_contracts mode) * Fallback tests: Simple syntax (fallback mode) * Disabled tests: No-op behavior testing - Set appropriate WILL_FAIL properties for all failure tests - Test structure now clearly separates native C++26 contract testing from HPX_ASSERT fallback behavior testing, providing comprehensive coverage of all contract modes. - added contracts in core
hkaiser
force-pushed
the
contract_test
branch
2 times, most recently
from
983587c to
0e1789e
Compare
- fixing remaining CI failures Signed-off-by: Hartmut Kaiser <[email protected]>
hkaiser
force-pushed
the
contract_test
branch
from
0e1789e to
c1a2e50
Compare
Member
|
@AlexPapadakis thank you for working on this! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
-added contracts module
-with fallback to asserts when contracts are not supported
-and option to enchance asserts with contract asserts
Any background context you want to provide?
more on the GSoC report here:
https://alexpapadakis.github.io/hpx_contracts/
Checklist
Not all points below apply to all pull requests.